Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CodeLens in diff editor #97640

Closed
ludokx opened this issue May 12, 2020 · 3 comments · Fixed by #97644
Closed

Support CodeLens in diff editor #97640

ludokx opened this issue May 12, 2020 · 3 comments · Fixed by #97644
Assignees
@alexdima
Labels
diff-editor Diff editor mode issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2020

Comments

@ludokx
Copy link
Contributor

ludokx commented May 12, 2020

Related to issue monaco-editor #1909, it would be great to be able to add code lenses to the diff editor (original and/or modified) but they are hard coded to be disabled in diff editors (see here).

It should be possible to enable CodeLens in the original/modified editor with editor options.
ludokx added a commit to ludokx/vscode that referenced this issue May 12, 2020
@ludokx
Add microsoft#97640: Added options to enable codelens for diff editors
106fc1a
ludokx added a commit to ludokx/vscode that referenced this issue May 12, 2020
@ludokx
Add microsoft#97640: Added options to enable codelens for diff editors
4f68d66
@ludokx ludokx mentioned this issue May 12, 2020
Merged
@alexdima alexdima self-assigned this May 13, 2020
@alexdima alexdima added diff-editor Diff editor mode issues feature-request Request for new features or functionality labels May 13, 2020
ludokx added a commit to ludokx/vscode that referenced this issue Jun 2, 2020
@ludokx
Add microsoft#97640: corrected code documentation
9b8d5cb
alexdima added a commit that referenced this issue Jul 10, 2020
@alexdima
Merge pull request #97644 from ludokx/diff-editor-codelens
9ada582 
Add #97640: Added options to enable codelens for diff editors
@alexdima
Copy link
Member

In VS Code, this is available via the setting diffEditor.codeLens, which acts very similarly to editor.codeLens.

@alexdima alexdima added the verification-needed Verification of issue is requested label Aug 4, 2020
@connor4312 connor4312 added the verified Verification succeeded label Aug 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
diff-editor Diff editor mode issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2020
Development

Successfully merging a pull request may close this issue.

Add #97640: Added options to enable codelens for diff editors ludokx/vscode
4 participants
@ludokx @connor4312 @alexdima and others