Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more shell script file extensions #97646

Merged
merged 2 commits into from
May 13, 2020

Conversation

9at8
Copy link
Member

@9at8 9at8 commented May 12, 2020

This PR fixes #95583 and fixes #97313

AFAIK the csh family of shells has a different syntax from the bash family of shells. So maybe we shouldn't add these shells? I could be wrong, and it's not significantly different, making it not too bad even if we do. 🤷‍♂️

Resources:

cc: @aeschli

@msftclas
Copy link

msftclas commented May 12, 2020

CLA assistant check
All CLA requirements met.

@aeschli aeschli merged commit 15bd662 into microsoft:master May 13, 2020
@aeschli aeschli added this to the May 2020 milestone May 13, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recognize more shell script files pdksh, dash, mksh, posh, hushlogin not highlighting as shell script code
3 participants