Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use message service before workbench is up #9769

Closed
weinand opened this issue Jul 26, 2016 · 2 comments
Closed

Cannot use message service before workbench is up #9769

weinand opened this issue Jul 26, 2016 · 2 comments
Assignees
Labels
debt Code quality issues

Comments

@weinand
Copy link
Contributor

weinand commented Jul 26, 2016

while testing #9690:
The 'take feedback survey' does not show up because it is posted too early.
Forcing another notification some time later, brings up both notifications.

@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Jul 26, 2016
@joaomoreno joaomoreno added this to the July 2016 milestone Jul 26, 2016
joaomoreno added a commit that referenced this issue Jul 26, 2016
@joaomoreno
Copy link
Member

joaomoreno commented Jul 26, 2016

It all boils down to this indirection which decouples the message list with the construction of the workbench. The MessageList can't know when the workbench is finally ready due to how we set up the whole infrastructure, so it just drops messages.

Had to push 5418b6c in order for it to work.

The DOM construction of the workbench should happen in its constructor. That way we don't need to have global IDs laying around and base widgets looking around for them...

@joaomoreno joaomoreno assigned bpasero and unassigned joaomoreno Jul 26, 2016
@joaomoreno joaomoreno modified the milestones: August 2016, July 2016 Jul 26, 2016
@bpasero bpasero changed the title Message service does not show notifications that were posted before UI is up Cannot use message service before workbench is up Aug 8, 2016
@bpasero bpasero added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Aug 8, 2016
@bpasero bpasero modified the milestones: Backlog, August 2016 Aug 8, 2016
@bpasero
Copy link
Member

bpasero commented Aug 8, 2016

Nice workaround skillz.

@bpasero bpasero modified the milestones: Backlog, September 2016 Aug 31, 2016
@bpasero bpasero closed this as completed in 38a61f3 Sep 5, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

3 participants