-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Proposal for multiline quick input #98098
Comments
Hey @chrmarti, this proposal (and the ready implementation) fixes a pretty annoying bug in git extension that has 112 upvotes and is 3 years old, not to mention it's a small change which is no-brainer & is pretty straight-forward. So I guess the reward to investment ratio is high enough that it would be great if you can prioritize it a little thanks :) |
@devanshj Please have patience and don't ping us. As you can see there are 5k issues and 200 PRs open, on top of all the monthly releases. There's a lot to work on. We'll get to it in time. |
FWIW I wouldn't call it a "feature-request" (I'm not requesting a feature) it's more of a "bugfix" (I'm providing a bugfix that involves adding a feature) because it's part of the process of getting this PR (which literally is a bugfix) merged. To answer the bot, #40295 (the issue that gets fixed by this proposal & PR) already has 114 upvotes and the api feature request has 25 upvotes. Also how I would want (it's okay if that's not what y'all want) this to proceed is that this should be added to current or next month (anything other than backlog really) milestone because clearly it makes the cut to be in them, that is what I was trying to say in the initial ping. |
I was just going to open a ticket to simply make the git commit box multiline... how do I vote for this issue? |
The 👍 you did counts as a vote afaict so you're good! Also this already has enough votes in the issues I've linked the reason I opened this is to discuss the api and track the lifecycle of it according to the guildlines. |
Just started coding my extension for VSCode, it lacs basic UI input methods. No multiline inputs, no way to design a simple dialog box (we need to use Electron apps like the Color Palette is using and do IPC...). I'm surprised VScode extension API lacks so many basic features. |
Feature needed, pleaaaase :) |
2022 - still no multiline inputs hahah |
Now it is 2023, and we are still waiting for this feature. 😶 By the way, ChatGPT suggests using |
This comment was marked as off-topic.
This comment was marked as off-topic.
Any update on this? |
This comment was marked as off-topic.
This comment was marked as off-topic.
Any update? |
Any Update?? |
Any update? |
Problem
Currently there's no way to take a multiline input via
showInputBox
. We need one because we useshowInputBox
to take the commit message (which can be multiline) in git extension. (#40295, #39969)Solution APIs
TLDR: allow passing a
multiline
property to theshowInputBox
optionsPROPOSED API: Allow passing a
multiline
property to theshowInputBox
options.Problem: Users can have
{ multiline: true, password: true }
which won't work because it's a textarea. More importantly in future there could be more options applicable to only multiline (eg an option mapping to textarea'srow
attribute) or to only singlelinePROPOSED Solution: It's okay just document it
Solution: It's okay just document it and throw an error if such case arises
Solution: make the type of options like
{ multiline?: false, password?: boolean } | { multiline?: true, password?: false }
API: Have another function called
showMultilineInputBox
that takes options only applicable to it (meaning doesn't takepassword
property as option)password
) exclusive to singleline. It would have been okay if we had a bunch of options only exclusive to multiline egmaxHeight
,autoGrow
,initialRows
, etc. or bunch of options exclusive to singlelineSolution Behaviors
TLDR: when
multiline
is set to true,showInputBox
shows a multline quick input where the user hits shift+enter to insert a newline and works exactly like current quick inputImplementation
For currently proposed api and behavior: #98042, demo
cc @jrieken @chrmarti @joaomoreno
The text was updated successfully, but these errors were encountered: