Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waitForExit API to TaskExecution #98483

Closed
ThadHouse opened this issue May 25, 2020 · 3 comments
Closed

Add waitForExit API to TaskExecution #98483

ThadHouse opened this issue May 25, 2020 · 3 comments
Assignees
Labels
api feature-request Request for new features or functionality tasks Task system issues
Milestone

Comments

@ThadHouse
Copy link

Currently there is no trivial way to wait for a TaskExecution to be completed. Before 1.44, there was a way to do this using onDidEndTaskProcess, however as of 1.44 this is broken, and a still open bug report (#96643). Instead of needing to do workarounds with callbacks and condition variables to wait for a task to complete, a much simpler solution would be to add a waitForExit(cancel: CancellationToken): Thenable<number> api directly to TaskExecution. This would allow an easy way to wait for a process to exit, without needing to go through callback nightmares, especially when those callbacks break.

@meganrogge
Copy link
Contributor

This should not be needed when #96643 is fixed

@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality tasks Task system issues
Projects
None yet
Development

No branches or pull requests

4 participants
@ThadHouse @meganrogge @alexr00 and others