Tasks (and TaskExecutions) are not === in the onDid(Start|End)Task callbacks.

[ashgti]

• VSCode Version: 1.44.2
• OS Version: macOS 10.5.4

Steps to Reproduce:

1. Create a new extension using yo code.
2. Add the following to the 'activate' function body:

	let disposable = vscode.commands.registerCommand('extension.helloWorld', async () => {
		let echoTask = new vscode.Task({type: "taskbug"}, vscode.TaskScope.Workspace, 'echo', 'taskbug', new vscode.ProcessExecution('/bin/echo', ['hello world']));

		const echoTaskExecution = await vscode.tasks.executeTask(echoTask);

		vscode.tasks.onDidStartTaskProcess(e => {
			if (e.execution === echoTaskExecution) {
				console.log(`Detected that my task started with pid ${e.processId}`);
			} else if (e.execution.task === echoTask) {
				console.log(`Detected that my task started with pid ${e.processId}`);
			}
		});

		vscode.tasks.onDidEndTaskProcess(e => {
			if (e.execution === echoTaskExecution) {
				console.log(`Detected that my task exited with exit code ${e.exitCode}`);
			} else if (e.execution.task === echoTask) {
				console.log(`Detected that my task exited with exit code ${e.exitCode}`);
			}
		});
	});

3. Run debug the extension and run the 'Hello World' command.

If you break inside the onDidStartTaskProcess and onDidEndTaskProcess that comparison fail, which means its difficult to determine when the task starts or ends.

It's worth noting that in VSCode 1.43 the above comparisons both work, but in 1.44 this is not working.

Does this issue occur when all extensions are disabled?: Yes

[ashgti]

I also checked Insiders for 1.45 and it also fails to compare the Task and TaskExecution objects in onDid(Start|End)TaskProcess callbacks.

[ashgti]

Related bug for TaskExecutions being comparable #47465

[ThadHouse]

This bug actually completely broke our extension. Is the milestone to fix this still May 2020? This is very blocking, especially since otherwise there is no way to wait for a task to be done and then do something with the result of that task.

[alexr00]

@ashgti and @ThadHouse I have pushed a fix that solves the task executions not being equal. If you can, please install the insiders build tomorrow and verify that the issue you were seeing is resolved. If you still see a problem with the next insiders build, please let me know as soon as possible so I can have time to fix it before the next release.

[ashgti]

Works for me! Thanks!

[badsyntax]

Related to bug #98080

I've also verified this change fixes that bug. Thanks 👍

@alexr00 can i ask why there are no tests for this change? it would be useful to add tests to prevent regressions.

[alexr00]

Added an API test.

[badsyntax]

After moving some code around in my extension, i'm seeing the race condition again. I've added some details to #98080 (comment)