Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back to old PowerShell syntax highlighting #9922

Closed
daviwil opened this issue Jul 28, 2016 · 2 comments
Closed

Roll back to old PowerShell syntax highlighting #9922

daviwil opened this issue Jul 28, 2016 · 2 comments
Assignees
Milestone

Comments

@daviwil
Copy link
Contributor

daviwil commented Jul 28, 2016

  • VSCode Version: 1.3.1
  • OS Version: All

For the 1.3.0 release of VS Code we introduced a new syntax file for PowerShell which ended up having a few critical bugs. Since we keep finding more issues with the new syntax file I think it's probably good to revert back to the old one before finishing the 1.4 release. I know you're in lock down mode right now, but is there any possibility that we could revert for this release so that users aren't troubled by the issues anymore?

I'll go ahead and submit a PR, feel free to accept or reject based on what you decide.

Thanks!

/cc @aeschli @egamma

@daviwil
Copy link
Contributor Author

daviwil commented Jul 28, 2016

Pull request here: #9923

@kieferrm kieferrm added this to the July 2016 milestone Jul 28, 2016
aeschli added a commit that referenced this issue Jul 29, 2016
Fix #9922: Roll back PowerShell syntax definition
@daviwil
Copy link
Contributor Author

daviwil commented Jul 29, 2016

Thanks guys!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants