Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workbench.colorCustomizations not kept when loaded from remote workspace #101433

Closed
yann-papouin opened this issue Jun 30, 2020 · 0 comments
Closed

workbench.colorCustomizations not kept when loaded from remote workspace #101433

yann-papouin opened this issue Jun 30, 2020 · 0 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders themes Color theme issues verified Verification succeeded
Milestone
June 2020

Comments

@yann-papouin
Copy link

yann-papouin commented Jun 30, 2020 •
edited

  • VSCode Version: 1.46.1
  • OS Version: Windows 10 and Ubuntu 16.04 on remote ssh

Steps to Reproduce:

  1. Connect to a remote ssh and create a workspace in an empty folder
  2. Create workspace settings with this:
    "workbench.colorCustomizations": {
        "editor.wordHighlightBackground": "#ffffff0a",
        "editor.selectionBackground": "#003f9e",
        "editor.selectionForeground": "#ffffff",
        "editor.selectionHighlightBackground": "#ff33cc66",
        "editorOverviewRuler.errorForeground": "#ff33cc",
        "editorOverviewRuler.addedForeground": "#006eff",
        "editorOverviewRuler.modifiedForeground": "#009c1a",
        "editorOverviewRuler.deletedForeground": "#bb0404",
        "editorOverviewRuler.bracketMatchForeground": "#00a2ff",
        "editor.wordHighlightBorder": "#ff5f5f",
        "activityBar.background": "#612e91",
        "titleBar.activeBackground": "#612e91",
        "titleBar.activeForeground": "#FDFBF5"
    },
  1. Color will apply immediately
  2. Reload window
  3. New colors flash once then revert to default

Note that it is a regression introduced in 1.46, 1.45 was fine.

Does this issue occur when all extensions are disabled?: ....
@yann-papouin yann-papouin reopened this Jun 30, 2020
@yann-papouin yann-papouin changed the title workbench.colorCustomizations not kept whe workbench.colorCustomizations not kept when loaded from remote workspace Jun 30, 2020
@aeschli aeschli added this to the June 2020 milestone Jul 1, 2020
@aeschli aeschli added themes Color theme issues bug Issue identified by VS Code Team member as probable bug labels Jul 1, 2020
@aeschli aeschli mentioned this issue Jul 1, 2020
Closed
@aeschli aeschli closed this as completed in 5069ddc Jul 3, 2020
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Jul 3, 2020
@aeschli @gjsjohnmurray
workbench.colorCustomizations not kept when loaded from remote worksp…
2ab48f9 
…ace. Fixes microsoft#101433
@9at8 9at8 added the verified Verification succeeded label Jul 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
4 participants
@yann-papouin @aeschli @9at8 and others