Fixes top and bottom border cut off on status bar item border

[jeanp413]

For the bottom border:

• The window border wasn't taken into account when calculating the layout
  

For the top border:

• This is tricky because the border is an absolute positioned pseudo-element
  I could change the outline-offset to -2px though not sure if it looks good enough
  

This PR fixes #101525

[isidorn]

Thanks for the PR. I think this makes sense, however also assigning to @sbatten so he gives it a review since he owns the layout code

[isidorn]

@sbatten friendly ping on this? Do you pan to review this?

@jeanp413 for the slow response this got out of date. If you are still interested in this is it possible that you get rid of merge conflicts and then I can look into merging this? Thanks a lot for great PRs!

[isidorn]

@jeanp413 thanks! I plan to review this week. Let's give some time for @sbatten to responde before that though.

[isidorn]

I tried this PR and it looks good and the changes make sense.
However the issue seems to be fixed already in vscode insdiers.
That is in insiders with HC theme the bottom border already gets nicely rendered. At least on my machine
Let me know if I am missing something here

[sbatten]

@isidorn I looked at the linked issue and it seems this fix the hover border case, not the focus case. I can reproduce the original issue in insiders and the behavior is different with the PR. However, I don't like that we don't show the top border. I think we should, in both focus and hover, show the top and bottom border.

[jeanp413]

@isidorn I can also reproduce in insiders, in your screenshot the status bar does not have a white bottom border, for that the window should not be maximized.

[isidorn]

@jeanp413 thanks for clarifying
However based on @sbatten will not merge this in, since he owns this code.