Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings Editor] Add extra bottom padding for lists in settings #101812

Merged
merged 1 commit into from Jul 6, 2020

Conversation

9at8
Copy link
Member

@9at8 9at8 commented Jul 6, 2020

Fixes: #101516

The add button was getting hidden under the next element in the settings
list, so I increased the bottom padding.

Fixes: #101516

The add button was getting hidden under the next element in the settings
list.
@9at8 9at8 requested a review from roblourens July 6, 2020 17:16
@9at8 9at8 changed the title Add extra bottom padding for lists in settings [Settings Editor] Add extra bottom padding for lists in settings Jul 6, 2020
@9at8 9at8 merged commit d69339a into master Jul 6, 2020
@9at8 9at8 deleted the adi/fix-add-button-clipping branch July 6, 2020 18:45
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this pull request Jul 8, 2020
Fixes: microsoft#101516

The add button was getting hidden under the next element in the settings
list.
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings object editor - UX delay after adding item
2 participants