Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot enable or disable extension #102645

Closed
Spongman opened this issue Jul 15, 2020 · 7 comments
Closed

cannot enable or disable extension #102645

Spongman opened this issue Jul 15, 2020 · 7 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2020

Comments

@Spongman
Copy link

Spongman commented Jul 15, 2020 •
edited

Issue Type: Bug

I cannot enable or disable the ms-vscode.cpptools extension.

repro steps:

  • install ms-vscode.cpptools
  • disable ms-vscode.cpptools
  • attempt to 'enable in workspace'

right-click shows me this:

image

and the details page only shows the 'Uninstall' button:

image

i'm pretty sure this is a regression.

VS Code version: Code 1.47.0 (d5e9aa0, 2020-07-09T08:02:06.629Z)
OS version: Windows_NT x64 10.0.19041
Remote OS version: Linux x64 3.10.0-1127.el7.x86_64

System Info
Item Value
CPUs Intel(R) Core(TM) i5-9400 CPU @ 2.90GHz (6 x 2904)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: enabled
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.66GB (4.87GB free)
Process Argv
Screen Reader no
VM 0%
Item Value
Remote SSH: 192.168.56.1:2222
OS Linux x64 3.10.0-1127.el7.x86_64
CPUs Intel(R) Core(TM) i5-9400 CPU @ 2.90GHz (6 x 2904)
Memory (System) 3.70GB (1.79GB free)
VM 100%
Extensions (10)
Extension Author (truncated) Version
vscode-intelephense-client bme 1.5.2
vscode-markdownlint Dav 0.36.1
gitlens eam 10.2.2
php-debug fel 1.13.0
cmake twx 0.0.17
change-case wma 1.0.0
plsql-language xyz 1.8.2
remote-ssh ms- 0.51.0
remote-ssh-edit ms- 0.51.0
remote-wsl ms- 0.44.4
@sandy081
Copy link
Member

I am not able to repro this. May I know how you are disabling the extension?

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Jul 17, 2020
@Spongman
Copy link
Author

i used the 'disable' and 'reload required' buttons in the details page.

@sandy081
Copy link
Member

You are in a VS Code Window that is connecting to WSL - I do not think it shall matter.

Can you please try to reproduce this on a Window that is not connecting to WSL?

If you are able to repro, can you please record the gif / video and share it with us?

@sandy081
Copy link
Member

I can reproduce this and it happens only in remote window (WSL).

As a workaround you can enable the extension from a normal window.

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions and removed info-needed Issue requires more information from poster labels Jul 23, 2020
@sandy081 sandy081 added this to the July 2020 milestone Jul 23, 2020
@sandy081 sandy081 mentioned this issue Jul 23, 2020
Closed
@seahindeniz
Copy link

Hi @sandy081

Thanks for referencing this issue. I'd searched for "built-in" related issues and missed this one. Sorry about that 🙂

The workaround you suggest can only be applied to extensions which has globally disabled. If an extension disabled only for a workspace, enabling from a normal window isn't going to help for WSL users, like me 🙁

I have also shared another workaround here #102905 (comment) but that is a "resetting" approach

PS: Following the instructions in here https://github.com/flowtype/flow-for-vscode/blob/master/README.md#setup, had lead me to have this issue in the first place. I didn't know I would be affected by following the instructions with a remote VSCode session.

  • Set javascript.validate.enable option to false or completely disable the built-in TypeScript extension for your project (see gif below):

@orta could you please add at least a warning for WSL users, till this issue has fixed?

@sandy081
Copy link
Member

sandy081 commented Jul 23, 2020 •
edited

The workaround you suggest can only be applied to extensions which has globally disabled. If an extension disabled only for a workspace, enabling from a normal window isn't going to help for WSL users, like me

Yes, it does not work for workspace disabled extensions.

Fixed it. This will be available in our next stable release in three weeks. You can also use our insiders tomorrow which will have the fix.

@sandy081
Copy link
Member

To verify

  • In a remote window (WSL / Container / SSH), disable any extension that exists on locally and remotely (also try built-in extensions) for the workspace
  • Reload window and make sure you can enable the extension back.

@connor4312 connor4312 added the verified Verification succeeded label Aug 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
5 participants
@Spongman @connor4312 @seahindeniz @sandy081 and others