Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default color tokens for last pinned tab border #108207

Merged
merged 1 commit into from Oct 7, 2020
Merged

Update default color tokens for last pinned tab border #108207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/theme-abyss/themes/abyss-color-theme.json
View file
Open in desktop
Expand Up @@ -390,7 +390,7 @@
"tab.inactiveBackground": "#10192c",
// "tab.activeForeground": "",
// "tab.inactiveForeground": "",
"tab.lastPinnedBorder": "#596F99",
"tab.lastPinnedBorder": "#2b3c5d",

// Workbench: Activity Bar
"activityBar.background": "#051336",
Expand Down
2 changes: 1 addition & 1 deletion extensions/theme-defaults/themes/light_defaults.json
View file
Open in desktop
Expand Up @@ -20,7 +20,7 @@
"statusBarItem.remoteBackground": "#16825D",
"sideBarSectionHeader.background": "#0000",
"sideBarSectionHeader.border": "#61616130",
"tab.lastPinnedBorder": "#81818130",
"tab.lastPinnedBorder": "#61616130",
"notebook.focusedCellBackground": "#c8ddf150",
"notebook.cellBorderColor": "#dae3e9",
"notebook.outputContainerBackgroundColor": "#c8ddf150"
Expand Down
2 changes: 1 addition & 1 deletion extensions/theme-kimbie-dark/themes/kimbie-dark-color-theme.json
View file
Open in desktop
Expand Up @@ -23,7 +23,7 @@
"editorGroupHeader.tabsBackground": "#131510",
"editorLineNumber.activeForeground": "#adadad",
"tab.inactiveBackground": "#131510",
"tab.lastPinnedBorder": "#5e452b",
"tab.lastPinnedBorder": "#51412c",
"titleBar.activeBackground": "#423523",
"statusBar.background": "#423523",
"statusBar.debuggingBackground": "#423523",
Expand Down
2 changes: 1 addition & 1 deletion extensions/theme-monokai/themes/monokai-color-theme.json
View file
Open in desktop
Expand Up @@ -35,7 +35,7 @@
"tab.inactiveBackground": "#34352f",
"tab.border": "#1e1f1c",
"tab.inactiveForeground": "#ccccc7", // needs to be bright so it's readable when another editor group is focused
"tab.lastPinnedBorder": "#75715E",
"tab.lastPinnedBorder": "#414339",
"widget.shadow": "#000000",
"progressBar.background": "#75715E",
"badge.background": "#75715E",
Expand Down
2 changes: 1 addition & 1 deletion extensions/theme-quietlight/themes/quietlight-color-theme.json
View file
Open in desktop
Expand Up @@ -472,7 +472,7 @@
"peekViewResult.background": "#F2F8FC",
"peekView.border": "#705697",
"peekViewResult.matchHighlightBackground": "#93C6D6",
"tab.lastPinnedBorder": "#C9D0D988",
"tab.lastPinnedBorder": "#c9d0d9",
"statusBar.background": "#705697",
"statusBar.noFolderBackground": "#705697",
"statusBar.debuggingBackground": "#705697",
Expand Down
2 changes: 1 addition & 1 deletion extensions/theme-solarized-light/themes/solarized-light-color-theme.json
View file
Open in desktop
Expand Up @@ -436,7 +436,7 @@
// "tab.activeBackground": "",
// "tab.activeForeground": "",
// "tab.inactiveForeground": "",
"tab.lastPinnedBorder": "#EEE8D5",
"tab.lastPinnedBorder": "#FDF6E3",

// Workbench: Activity Bar
"activityBar.background": "#DDD6C1",
Expand Down
6 changes: 3 additions & 3 deletions src/vs/workbench/common/theme.ts
View file
Open in desktop
Expand Up @@ -4,7 +4,7 @@
*--------------------------------------------------------------------------------------------*/

import * as nls from 'vs/nls';
import { registerColor, editorBackground, contrastBorder, transparent, editorWidgetBackground, textLinkForeground, lighten, darken, focusBorder, activeContrastBorder, editorWidgetForeground, editorErrorForeground, editorWarningForeground, editorInfoForeground } from 'vs/platform/theme/common/colorRegistry';
import { registerColor, editorBackground, contrastBorder, transparent, editorWidgetBackground, textLinkForeground, lighten, darken, focusBorder, activeContrastBorder, editorWidgetForeground, editorErrorForeground, editorWarningForeground, editorInfoForeground, treeIndentGuidesStroke } from 'vs/platform/theme/common/colorRegistry';
import { IColorTheme } from 'vs/platform/theme/common/themeService';
import { Color } from 'vs/base/common/color';

Expand Down Expand Up @@ -116,8 +116,8 @@ export const TAB_BORDER = registerColor('tab.border', {
}, nls.localize('tabBorder', "Border to separate tabs from each other. Tabs are the containers for editors in the editor area. Multiple tabs can be opened in one editor group. There can be multiple editor groups."));

export const TAB_LAST_PINNED_BORDER = registerColor('tab.lastPinnedBorder', {
dark: null,
light: null,
dark: treeIndentGuidesStroke,
light: treeIndentGuidesStroke,
hc: contrastBorder
}, nls.localize('lastPinnedTabBorder', "Border to separate pinned tabs from other tabs. Tabs are the containers for editors in the editor area. Multiple tabs can be opened in one editor group. There can be multiple editor groups."));

Expand Down