Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI items are incorrect order when applying the language pack #109433

Merged
merged 1 commit into from Oct 28, 2020
Merged

UI items are incorrect order when applying the language pack #109433

merged 1 commit into from Oct 28, 2020

Conversation

bicstone
Copy link
Contributor

@bicstone bicstone commented Oct 27, 2020 •
edited

This PR fixes #109286

https://code.visualstudio.com/api/references/contribution-points#Sorting-inside-groups

The current default sort order by is translated titles.

This order has the following problems:

  • When install/uninstall the language pack, menu order would be unexpectedly changed.
  • When translated title is changed, menu order would be unexpectedly changed.

I propose that the default sort order is by original titles.

@joaomoreno joaomoreno assigned jrieken and unassigned joaomoreno Oct 27, 2020
@jrieken jrieken added this to the October 2020 milestone Oct 28, 2020
@jrieken jrieken added the menus Menu items and widget issues label Oct 28, 2020
@jrieken
Copy link
Member

jrieken commented Oct 28, 2020

Thanks. Very clever default for when no explicit order in provided

@jrieken jrieken merged commit b2d76ac into microsoft:master Oct 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken approved these changes

Assignees

@jrieken jrieken

Labels
menus Menu items and widget issues
Projects
None yet
Milestone
October 2020
Development

Successfully merging this pull request may close these issues.

UI items are incorrect order when applying the language pack
3 participants
@bicstone @jrieken @joaomoreno