Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color token for error background #110112

Merged
merged 3 commits into from Nov 9, 2020
Merged

Conversation

miguelsolorio
Copy link
Contributor

Fixes #16204 and adds a new color token for error background colors, editorError.background:

image

Followed the same naming convention as:

  • editorError.border
  • editorError.foreground

@aeschli
Copy link
Contributor

aeschli commented Nov 9, 2020

The color needs to be transparent to work with other highlight colors. We should add that information to the description. There's also a boolean parameter on registerColor to signal that.
Example:

export const editorRangeHighlight = registerColor('editor.rangeHighlightBackground', { dark: '#ffffff0b', light: '#fdff0033', hc: null }, nls.localize('rangeHighlight', 'Background color of highlighted ranges, like by quick open and find features. The color must not be opaque so as not to hide underlying decorations.'), true);

What about the other problem types? Warning, info, ...

@miguelsolorio
Copy link
Contributor Author

@aeschli thanks for the pointer, I'll update this and also add the other types.

@miguelsolorio
Copy link
Contributor Author

Updated and added editorWarning.background and editorInfo.background:

image

@miguelsolorio miguelsolorio merged commit 701e671 into master Nov 9, 2020
@miguelsolorio miguelsolorio deleted the misolori/squiggles-bg-theme branch November 9, 2020 20:58
@miguelsolorio miguelsolorio added this to the November 2020 milestone Nov 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Themeing for editor squiggles background
3 participants