Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support greater than and less than #110846

Merged
merged 5 commits into from Dec 2, 2020
Merged

Support greater than and less than #110846

merged 5 commits into from Dec 2, 2020

Conversation

Wscats
Copy link
Contributor

@Wscats Wscats commented Nov 18, 2020

Hope contextkey.ts supports greater than and less than, to facilitate the extension of features.

@ghost
Copy link

ghost commented Nov 18, 2020

CLA assistant check
All CLA requirements met.

@roblourens
Copy link
Member

Is there an issue for this feature?

@Wscats
Copy link
Contributor Author

Wscats commented Nov 18, 2020

Is there an issue for this feature?

With a small change here, a more precise and simple comparison can be made, Can be used for comparison, such as gitOpenRepositoryCount > 0, workspaceFolderCount > 2, editor.cursorSurroundingLines/editor.fontSize/editor.lineHeight and the extension can be more flexible.

"menus": {
      "commandPalette": [
        {
          "command": "git.close",
          "when": "gitOpenRepositoryCount > 0"
        },
        {
          "command": "git.refresh",
          "when": "gitOpenRepositoryCount > 0"
        },
}

"viewsWelcome": [
      {
        "view": "scm",
        "contents": "%view.workbench.scm.workspace%",
        "when": "workspaceFolderCount > 2"
      },
]

@alexdima alexdima added this to the November 2020 milestone Dec 2, 2020
@alexdima alexdima merged commit 980ef5c into microsoft:master Dec 2, 2020
@alexdima
Copy link
Member

alexdima commented Dec 2, 2020

Thank you!

1 similar comment
@Wscats
Copy link
Contributor Author

Wscats commented Dec 2, 2020

Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants