externalize notebook items #111408
Merged
externalize notebook items #111408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pushed the changes so we can find issues in testing week. |
roblourens
reviewed
Dec 1, 2020
There was a problem hiding this comment.
Is this so that extensions can contribute icons? The granularity is interesting. I would have expected that I would contribute one icon for everything that means "delete", not that there would be a notebook-delete-cell icon and a different delete icon somewhere else. Looks fine to me though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Externalize notebook icons
Please review the icon names and descriptions in
notebookIcons.I tested the changes, but I'm no export user of the notebooks.
E.g. I got to see the folding icons but didn't undertand if/how they work (same behavior without my changes)