Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clojure: Use ;; instead of ; for line comments #115036

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

joaomoreno
Copy link
Member

@plexus says:

LISPs in general and Clojure in particular by convention uses double semicolons
for regular line comments. Single semicolons are reserved for trailing comments
at the end of a line, and are treated (aligned) differently in some editors,
notably Emacs.

LISPs in general and Clojure in particular by convention uses double semicolons
for regular line comments. Single semicolons are reserved for trailing comments
at the end of a line, and are treated (aligned) differently in some editors,
notably Emacs.
@joaomoreno joaomoreno added this to the January 2021 milestone Jan 26, 2021
@joaomoreno joaomoreno self-assigned this Jan 26, 2021
@joaomoreno
Copy link
Member Author

@plexus says:

This is something a lot of Calva users are complaining about, blaming Calva even though it's really an upstream issue: BetterThanTomorrow/calva#971

@joaomoreno
Copy link
Member Author

@alexr00 says:

Thanks for the PR! Can you point me to some language documentation so I can learn more?

@joaomoreno
Copy link
Member Author

@plexus says:

See for example the community style guide: https://github.com/bbatsov/clojure-style-guide#comments

@joaomoreno
Copy link
Member Author

@plexus says:

Thanks for the quick merge!

@joaomoreno
Copy link
Member Author

@ArturoDent says:

@plexus - purely as a very short-term workaround until the next release in a couple of weeks, you can change lineComment form with this extension: Custom Language Properties.

"custom-language-properties": {
  "clojure.comments.lineComment": ";;"
 },

@joaomoreno
Copy link
Member Author

@plexus @alexr00 We have reverted the decision to extract extensions from the microsoft/vscode repo, so I've recreated @plexus's PR from vscode-clojure, so we don't lose the discussion.

@joaomoreno joaomoreno merged commit 1f1ed78 into master Jan 26, 2021
@joaomoreno joaomoreno deleted the joao/plexus/double-semicolon-line-comments branch January 26, 2021 13:01
@joaomoreno joaomoreno changed the title Use ;; instead of ; for line comments Clojure: Use ;; instead of ; for line comments Jan 26, 2021
tshakalekholoane added a commit to tshakalekholoane/vscode-hy that referenced this pull request Jan 27, 2021
tshakalekholoane added a commit to tshakalekholoane/vscode-hy that referenced this pull request Jan 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants