Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notebook outputs api #115817

Merged
merged 55 commits into from Feb 11, 2021
Merged

notebook outputs api #115817

merged 55 commits into from Feb 11, 2021

Commits on Feb 4, 2021

  1. output always contains id

    @rebornix
    rebornix committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    b5ba200 View commit details
    Browse the repository at this point in the history

  2. IRawOutput -> IOutputDto

    @rebornix
    rebornix committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    a81dd8d View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. reuse display output as the single output type for rendering

    @rebornix
    rebornix committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    4d6d226 View commit details
    Browse the repository at this point in the history

  2. Extensions do not update cell outputs/metadata directly.

    @rebornix
    rebornix committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    f2b87fd View commit details
    Browse the repository at this point in the history

  3. fix tests.

    @rebornix
    rebornix committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    0df177f View commit details
    Browse the repository at this point in the history

  4. fix smoke test typings.

    @rebornix
    rebornix committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    2ff5b90 View commit details
    Browse the repository at this point in the history

  5. make extHost only send ITransformedDisplayOutputDto (convert error, t… 

    …ext output inside the ext host)
    @jrieken
    jrieken committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    77bbee5 View commit details
    Browse the repository at this point in the history

  6. add NotebookCell#output2

    @jrieken
    jrieken committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    f3fd96e View commit details
    Browse the repository at this point in the history

  7. remove need to massage ids onto output items

    @jrieken
    jrieken committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    6f936f9 View commit details
    Browse the repository at this point in the history

  8. remove used dto interfaces

    @jrieken
    jrieken committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    8522c22 View commit details
    Browse the repository at this point in the history

  9. Revert "remove used dto interfaces" 

    This reverts commit 8522c22.
    @jrieken
    jrieken committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    1b4a902 View commit details
    Browse the repository at this point in the history

  10. add deprecation tags, remove unreferenced types, add more todos

    @jrieken
    jrieken committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    b3a0d08 View commit details
    Browse the repository at this point in the history

  11. todo-comment update

    @jrieken
    jrieken committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    e136ed6 View commit details
    Browse the repository at this point in the history

  12. internal output types always have id

    @rebornix
    rebornix committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    a3ef264 View commit details
    Browse the repository at this point in the history

  13. OutputDto always has id

    @rebornix
    rebornix committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    175ac0e View commit details
    Browse the repository at this point in the history

  14. 💄

    @rebornix
    rebornix committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    3c17b03 View commit details
    Browse the repository at this point in the history

  15. no error and stream output anymore

    @rebornix
    rebornix committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    0a97294 View commit details
    Browse the repository at this point in the history

  16. convert output exthost/main. not optimized.

    @rebornix
    rebornix committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    5024a70 View commit details
    Browse the repository at this point in the history

  17. rich mimetype renderer refactor

    @rebornix
    rebornix committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    9f4772a View commit details
    Browse the repository at this point in the history

  18. rename.

    @rebornix
    rebornix committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    90327ba View commit details
    Browse the repository at this point in the history

  19. RenderType.mainframe

    @rebornix
    rebornix committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    008e5c7 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2021

  1. append/replace output items

    @rebornix
    rebornix committed Feb 6, 2021
    Configuration menu
    Copy the full SHA
    03fdd53 View commit details
    Browse the repository at this point in the history

  2. append or replace mimetypes.

    @rebornix
    rebornix committed Feb 6, 2021
    Configuration menu
    Copy the full SHA
    659245f View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. move convert logic into extHostTypeConverters

    @jrieken
    jrieken committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    4821adf View commit details
    Browse the repository at this point in the history

  2. fix compile errors

    @jrieken
    jrieken committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    83a2eb4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into notebook/outputs

    @jrieken
    jrieken committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    e3d0d9c View commit details
    Browse the repository at this point in the history

  4. remove unused types

    @jrieken
    jrieken committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    67bac9b View commit details
    Browse the repository at this point in the history

  5. move interface to its sole user

    @jrieken
    jrieken committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    809bbd7 View commit details
    Browse the repository at this point in the history

  6. 💄 strict assertions

    @jrieken
    jrieken committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    a873e60 View commit details
    Browse the repository at this point in the history

  7. NotebookDocument#metadata is readonly

    @jrieken
    jrieken committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    3edc992 View commit details
    Browse the repository at this point in the history

  8. remove legacy typings.

    @rebornix
    rebornix committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    0544c1d View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. fix outputs loading

    @rebornix
    rebornix committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    779938d View commit details
    Browse the repository at this point in the history

  2. auto save ...

    @rebornix
    rebornix committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    bd47ac8 View commit details
    Browse the repository at this point in the history

  3. new output type shape only.

    @rebornix
    rebornix committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    fd6997f View commit details
    Browse the repository at this point in the history

  4. builtin renderer handles OutputItem.

    @rebornix
    rebornix committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    6ba6002 View commit details
    Browse the repository at this point in the history

  5. handle append/replace output items.

    @rebornix
    rebornix committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    d94093a View commit details
    Browse the repository at this point in the history

  6. notebook diff editor handle empty mimetypes.

    @rebornix
    rebornix committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    99f4a02 View commit details
    Browse the repository at this point in the history

  7. fix notebook worker dto

    @rebornix
    rebornix committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    e02e968 View commit details
    Browse the repository at this point in the history

  8. Revert "notebook diff editor handle empty mimetypes." 

    This reverts commit 99f4a02.
    @rebornix
    rebornix committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    538c784 View commit details
    Browse the repository at this point in the history

  9. do not render if there is no mimetype at all.

    @rebornix
    rebornix committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    a05c417 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/master' into notebook/outputs

    @rebornix
    rebornix committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    11b885d View commit details
    Browse the repository at this point in the history

  11. implment getCellViewModel for side by side diff editor.

    @rebornix
    rebornix committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    97998b3 View commit details
    Browse the repository at this point in the history

  12. [renderer] fix string conversion for numbers

    @rebornix
    rebornix committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    4090343 View commit details
    Browse the repository at this point in the history

  13. resize observer does not count padding.

    @rebornix
    rebornix committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    8799924 View commit details
    Browse the repository at this point in the history

  14. diff editor compare outputs should ignore outputid

    @rebornix
    rebornix committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    81c7bdd View commit details
    Browse the repository at this point in the history

  15. style polish

    @rebornix
    rebornix committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    ebc2386 View commit details
    Browse the repository at this point in the history

  16. send mimetype specific metadata to webview

    @rebornix
    rebornix committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    aa1e745 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. unknown metadata value.

    @rebornix
    rebornix committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    6c47905 View commit details
    Browse the repository at this point in the history

  2. cell execution API sketches

    @jrieken
    jrieken committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    e58a5e8 View commit details
    Browse the repository at this point in the history

  3. more api todos

    @jrieken
    jrieken committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    60898cf View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into notebook/outputs

    @jrieken
    jrieken committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    b881f37 View commit details
    Browse the repository at this point in the history

  5. allow custom id in NotebookCellOutput

    @jrieken
    jrieken committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    0e139c6 View commit details
    Browse the repository at this point in the history

  6. remove CellOutputKind type

    @jrieken
    jrieken committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    cf7fc39 View commit details
    Browse the repository at this point in the history

  7. fix metadata complile error

    @jrieken
    jrieken committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    6ed5c53 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Merge branch 'master' into notebook/outputs

    @jrieken
    jrieken committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    6c92a66 View commit details
    Browse the repository at this point in the history