fix: CreateFile ERROR_FILE_NOT_FOUND from crashpad handler

[deepak1556]

Fixes #115874
Fixes #112216

[bpasero]

I feel this could possibly improve. To give some background, the first startup will get a process.env from here:

vscode/src/vs/code/electron-main/main.ts

Lines 202 to 217 in 2baf63a

	private patchEnvironment(environmentService: IEnvironmentMainService): IProcessEnvironment {
	const instanceEnvironment: IProcessEnvironment = {
	VSCODE_IPC_HOOK: environmentService.mainIPCHandle
	};
	['VSCODE_NLS_CONFIG', 'VSCODE_PORTABLE'].forEach(key => {
	const value = process.env[key];
	if (typeof value === 'string') {
	instanceEnvironment[key] = value;
	}
	});
	Object.assign(process.env, instanceEnvironment);
	return instanceEnvironment;
	}

This will end up as initialUserEnv into each window as you can see here:

vscode/src/vs/platform/windows/electron-main/windowsMainService.ts

Line 1143 in 14cc526

configuration.userEnv = { ...this.initialUserEnv, ...options.userEnv };

The userEnv will overwrite anything and thus probably leading to CHROME_CRASHPAD_PIPE_NAME getting the bad value for the window.

Now, instead of patching the environment in the launch main service, I would rather suggest to fix it centrally where we define the environment for the window itself, here:

vscode/src/vs/code/electron-main/window.ts

Line 693 in c023260

load(config: INativeWindowConfiguration, { isReload, disableExtensions }: { isReload?: boolean, disableExtensions?: boolean } = Object.create(null)): void {

We already have code to change the userEnv. I would suggest to overwrite CHROME_CRASHPAD_PIPE_NAME with the value from process somewhere there so that we make sure no other code path of opening a window would hit the same issue.

[bpasero]

Yeah that looks better to me. Not sure why we would need to check this:

if (process.env['CHROME_CRASHPAD_PIPE_NAME'] !== config.userEnv['CHROME_CRASHPAD_PIPE_NAME']) {

I think we could always assign the value over, no?

[deepak1556]

I think we could always assign the value over, no?

Yup we can, was trying to avoid object.assign when not needed but there is no value here. Fixed.