Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webview focus issues that prevent cut/copy/paste when opening files with a quick pick #116899

Merged
merged 5 commits into from Feb 19, 2021
Merged

Fix webview focus issues that prevent cut/copy/paste when opening files with a quick pick #116899

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8916a7a
Merge pull request #1 from microsoft/master
tspence Jan 25, 2021
0a136c4
Enable issue service dialog to launch when remote extension host fail…
Jan 25, 2021
edc6dcc
Prevent delayed focus change from setting _focused
tspence Feb 18, 2021
2deb46d
Update issueService.ts
tspence Feb 18, 2021
2b70541
Update issueService.ts
tspence Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/vs/workbench/contrib/webview/browser/baseWebviewElement.ts
View file
Open in desktop
Expand Up @@ -318,10 +318,11 @@ export abstract class BaseWebview<T extends HTMLElement> extends Disposable {
}

protected handleFocusChange(isFocused: boolean): void {
this._focused = isFocused;
if (isFocused) {
if (isFocused && this.element === document.activeElement) {
this._focused = true;
this._onDidFocus.fire();
} else {
this._focused = false;
this._onDidBlur.fire();
}
}
Expand Down