Don't call node-gyp anymore (#120673) #120733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This npx call was installing node-gyp 8.0 which requires a newer version of Python then what's in our containers. I've removed it but also followed the advice of the comment that says only remove it if prebuild-install is updated in keytar... So I updated keytar's dependencies which pulled in prebuild-install 6.1.1 with the fix. If this isn't the right move, feel free to revert and then we can move to Debian Buster which has a version of Python that is new enough.
joaomoreno
added
the
candidate
jrieken
approved these changes
Apr 7, 2021
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #120673 but for 1.55, to unblock the build