Remove --no-sandbox
#122909
Merged
Remove --no-sandbox
#122909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not disable sandbox on Linux. We only added this to support running on Kernel <= 3.8 where setuid sandbox is used.
|
cc @joaomoreno @Tyriar for snap etc. We want to move away from disabling the sandbox because we will eventually enable it. Any distro using linux kernel version <= 3.8 will default to setuid sandbox but that is a very old Kernel. We only need to keep it for our CI where docker is used. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only keep disabling suid sandbox in CI.
//cc @deepak1556