Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Inline Completions To Preselect Item In Autocomplete #132866

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

hediet
Copy link
Member

@hediet hediet commented Sep 10, 2021

The suggest widget is not being stopped from automatically opening anymore if suggest preview is enabled. Instead, the first inline suggestion is used to preselect an item in the suggest widget.

This PR fixes #131940.

…matically opening anymore if suggest preview is enabled. Instead, the first inline suggestion is used to preselect an item in the suggest widget.
@hediet hediet requested a review from jrieken September 10, 2021 14:50
@hediet hediet self-assigned this Sep 10, 2021
@hediet hediet added this to the September 2021 milestone Sep 10, 2021
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nit

src/vs/editor/contrib/suggest/suggestController.ts Outdated Show resolved Hide resolved
src/vs/editor/contrib/suggest/suggestModel.ts Outdated Show resolved Hide resolved
@hediet hediet merged commit 634e7b4 into main Sep 14, 2021
@hediet hediet deleted the hediet/autocomplete-preselect-from-inline-suggestion branch September 14, 2021 08:54
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If Intellicode Whole Line Completions are displayed, the suggestions widget does not open
2 participants