Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cross-product FS-provided imports #133116

Merged
merged 8 commits into from Sep 22, 2021
Merged

Support cross-product FS-provided imports #133116

merged 8 commits into from Sep 22, 2021

Conversation

sbatten
Copy link
Member

@sbatten sbatten commented Sep 14, 2021

This PR allows for cross-product drag and drop of files from file system providers as long as the provider exists in the destination

@sbatten sbatten self-assigned this Sep 14, 2021
@sbatten sbatten added this to the September 2021 milestone Sep 14, 2021
bpasero
bpasero requested changes Sep 15, 2021
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not really understand the changes in explorerViewer.ts

src/vs/workbench/contrib/files/browser/views/explorerViewer.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/files/browser/fileImportExport.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/files/browser/views/explorerViewer.ts Outdated Show resolved Hide resolved
@isidorn
Copy link
Contributor

isidorn commented Sep 15, 2021

I yield my review to Jackson.
Jackson if I can help feel free to re-assign me. Thanks!

@isidorn isidorn removed their request for review September 15, 2021 14:16
@sbatten
Copy link
Member Author

sbatten commented Sep 16, 2021

@bpasero some cleanup based on the feedback for clarity. lmk

@sbatten
Copy link
Member Author

sbatten commented Sep 16, 2021

@bpasero added the activation with this commit 03cd053

as you mentioned before this doesn't work when dragging out of codespaces. i wonder if we could translate the resource into something else. it seems like the github extensions should have interoperability

@bpasero
Copy link
Member

bpasero commented Sep 17, 2021

i wonder if we could translate the resource into something else. it seems like the github extensions should have interoperability

This would be very GH specific, not sure I like that. Because we don't really know what the target has installed in terms of extensions...

@egamma egamma mentioned this pull request Sep 20, 2021
Closed
99 tasks
@sbatten sbatten merged commit 0ad3cca into main Sep 22, 2021
@sbatten sbatten deleted the fsDnd branch September 22, 2021 18:44
@sbatten sbatten mentioned this pull request Sep 28, 2021
Closed
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

@JacksonKearl JacksonKearl Awaiting requested review from JacksonKearl

Assignees

@sbatten sbatten

Labels
None yet
Projects
None yet
Milestone
September 2021
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbatten @isidorn @bpasero