Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests should be faster 馃悗 #135075

Closed
16 tasks done
jrieken opened this issue Oct 14, 2021 · 2 comments
Closed
16 tasks done

Unit tests should be faster 馃悗 #135075

jrieken opened this issue Oct 14, 2021 · 2 comments
Assignees
@mjbvz
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc.
Milestone
November 2021

Comments

@jrieken
Copy link
Member

jrieken commented Oct 14, 2021 •
edited by mjbvz

This the continuation of #134972

馃摙 Another shout the the runWithFakedTimers-util

  • 252ms, Provider should not be retriggered if previous help is canceled first @mjbvz
  • 253ms, asyncRenderCallback should not be invoked if result is immediately disposed @mjbvz
  • 254ms, corrupt DB recovers @bpasero
  • 255ms, Orcale -> position changed @mjbvz
  • 257ms, Orcale -> marker added @mjbvz
  • 257ms, Lightbulb is in the wrong place, Lightbulb is in the wrong place聽#29933 @mjbvz
  • 263ms, Retrigger while a pending resolve is still going on should preserve last active signature Signature help selection changes while typing聽#96702 @mjbvz
  • 303ms, Provider should be retriggered if already active @mjbvz
  • 311ms, Orcale -> should only auto trigger once for cursor and marker update right after each other @mjbvz
  • 323ms, test donotMakeRequestsUntil is reset after retry time is finished @sandy081
  • 325ms, clear @bpasero
  • 329ms, test donotMakeRequestsUntil is checked and reset after retreived @sandy081
  • 380ms, createFile (mixed parallel/sequential) @JacksonKearl
  • 411ms, resolve terminal encoding (detect) @bpasero
  • 503ms, asyncRenderCallback should not be invoked if dispose is called before code block is rendered @mjbvz
  • 545ms, buffered sending - simple data @bpasero
@jrieken jrieken added the debt Code quality issues label Oct 14, 2021
JacksonKearl pushed a commit that referenced this issue Oct 14, 2021
Speed up createFile unit test
9bb86e9 
ref #135075
@aeschli aeschli removed their assignment Oct 15, 2021
@bpasero bpasero added the engineering VS Code - Build / issue tracking / etc. label Oct 19, 2021
sandy081 added a commit that referenced this issue Oct 21, 2021
@sandy081
#135075 Use fake timers
6c7b2b3
@sandy081 sandy081 removed their assignment Oct 21, 2021
@bpasero bpasero added this to the November 2021 milestone Oct 23, 2021
bpasero added a commit that referenced this issue Oct 25, 2021
@bpasero
storage - use fake timers for clear test (#135075)
bbf53ed
bpasero added a commit that referenced this issue Oct 25, 2021
@bpasero
backups - use fake timers in some slow tests (#135075)
1c0447f
bpasero added a commit that referenced this issue Oct 25, 2021
@bpasero
tests - more runWithFakedTimers usage (#135075)
2bf992d
@bpasero
Copy link
Member

bpasero commented Oct 25, 2021

The runWithFakedTimers utility is 馃憤 .

My 4 remaining ones are still being somewhat slow due to 2 reasons:

  • 2 actually spawn processes on disk to test something
  • 2 end up calling our writeFileSync method that calls fdatasyncSync which is slower than just writing to disk. but I still feel it important to test this code given it is used for backups

I could move them to integration tests but it is a bit arbitrary, at least for the ones using fdatasyncSync...

@JacksonKearl JacksonKearl removed their assignment Oct 25, 2021
bpasero added a commit that referenced this issue Oct 28, 2021
@bpasero
tests - convert more slow tests to integration tests (#135075)
ad6da1b
@bpasero bpasero removed their assignment Nov 1, 2021
mjbvz added a commit that referenced this issue Nov 20, 2021
@mjbvz
Reduce timeout
4c83c13 
For #135075
mjbvz added a commit that referenced this issue Nov 20, 2021
@mjbvz
Reduce delay in test
edfee5c 
For #135075
mjbvz added a commit that referenced this issue Nov 20, 2021
@mjbvz
Speed up tests with take timers
aa81077 
For #135075
mjbvz added a commit that referenced this issue Nov 20, 2021
@mjbvz
Use runWithFakedTimers in more tests
6fc3332 
For #135075
@mjbvz
Copy link
Contributor

mjbvz commented Nov 20, 2021

I reviewed mine and adopted runWithFakeTimers for most. A handful are still slow, specifically the ones where I'm trying to test that something has not happened. Keeping them for now

@mjbvz mjbvz closed this as completed Nov 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
6 participants
@bpasero @jrieken @aeschli @JacksonKearl @sandy081 @mjbvz