Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for extension contributions in welcome.showAllWalkthroughs #135632

Merged
merged 4 commits into from Mar 3, 2022

Conversation

yume-chan
Copy link
Contributor

This PR fixes #135487

Another option is to hide Get Started: Open Walkthrough... and Get Started: Go Back commands from command palette (especially the go back, doesn't seem to be useful, as closeFindWidget command is not there)

@JacksonKearl
Copy link
Contributor

Thanks for the PR! I agree Get Started: Go Back should not be in F1 menu, but I disagree that Get Started: Open Walkthrough... should not.

For this patch, if I remember correctly the issue with waiting for the extensions to be registered is that it may depend on the file system being scanned to facilitate the featuredFor flag, which could amount to a large delay. The real fix would be to provide the list without waiting for that scan, as we perhaps don't need it for this case. Or, configuring the quick pick to stream in walkthroughs as they are added.

@JacksonKearl JacksonKearl self-requested a review October 23, 2021 00:51
@yume-chan
Copy link
Contributor Author

yume-chan commented Oct 23, 2021

Now I show the quick pick immediately with built-in walk throughs and a loading indicator, then update the quick pick items after all extension contributions are fetched.

@yume-chan
Copy link
Contributor Author

The failed tests are from integrated terminal.

@JacksonKearl
Copy link
Contributor

Thanks for working on this!

@JacksonKearl JacksonKearl merged commit c7eeab6 into microsoft:main Mar 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List extension walkthroughs in the `Get Started: Open Walkthrough ..." picker
2 participants