Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[html] Hitting return after </button> element crashes VS Code (Insiders) #135806

Closed
Tman7077 opened this issue Oct 25, 2021 · 2 comments
Closed

[html] Hitting return after </button> element crashes VS Code (Insiders) #135806

Tman7077 opened this issue Oct 25, 2021 · 2 comments
Assignees
@aeschli
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues html HTML support issues insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken
Milestone
October 2021

Comments

@Tman7077
Copy link

Issue Type: Bug

Here is my code right now: https://pastebin.com/B96JMqwM
In the HTML , there is one button, and if I put my cursor at the end of that line (after ), then press the enter/return key, VS Code crashes. I don't know what could be causing this, but it happens every time. If I select the beginning of the next line (before <div ...), then hit the same key, the desired result is accomplished, and VS Code does not crash. This "desired result" is simply adding another line, as any return key would. On VS Code Insiders, Windows 11.

VS Code version: Code - Insiders 1.62.0-insider (45fdad3, 2021-10-25T05:14:01.458Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i5-10300H CPU @ 2.50GHz (8 x 2496)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.78GB (3.37GB free)
Process Argv --crash-reporter-id 2593ce2b-09a5-426d-8b71-2a9f08725585
Screen Reader no
VM 0%
Extensions (1)
Extension Author (truncated) Version
webvalidator Cel 1.2.1
A/B Experiments 
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383:30185418
pythonvspyt602:30291494
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256197
pythonvspyt639:30291487
pythontb:30258533
pythonvspyt551cf:30291413
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
pythonvsuse255:30319630
vscod805cf:30301675
pythonvspyt200:30323110
vsccppwt:30382699
pythonvssor306:30340298
bridge0708:30335490
pygetstartedt2:30353727
bridge0723:30353136
pythonrunftest32:30365365
pythonf5test824:30361779
javagetstartedt:30350119
pythonvspyt187:30365360
pydsgst2:30361790
vsaa593:30376534
vscrecpromptc:30387006
@JacksonKearl JacksonKearl added the freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues label Oct 26, 2021
@JacksonKearl
Copy link
Contributor

JacksonKearl commented Oct 26, 2021 •
edited

Confirmed also crashes with that sample file on MacOS. Not able to reproduce on stable.
Minimal reproduction:

<button attr1=val1 attr2=val2></button>

the above takes a very long time to run an "enter" from within the closing </button>, making the contents longer causes it to crash.

@JacksonKearl JacksonKearl added the regression Something that used to work is now broken label Oct 26, 2021
@JacksonKearl
Copy link
Contributor

@aeschli traced to onEnter here taking a long time to execute the regex. Perhaps from 7fefb2f?

This was referenced Oct 26, 2021
Closed
Closed
@aeschli aeschli changed the title Hitting return after </button> element crashes VS Code (Insiders) [html] Hitting return after </button> element crashes VS Code (Insiders) Oct 26, 2021
@aeschli aeschli added the html HTML support issues label Oct 26, 2021
@aeschli aeschli added this to the October 2021 milestone Oct 26, 2021
@gjsjohnmurray gjsjohnmurray mentioned this issue Oct 26, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues html HTML support issues insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
4 participants
@aeschli @JacksonKearl @Tman7077 and others