[typescript-language-features] Add includeCompletionsWithClassMemberSnippets preference #136045
Conversation
There was a problem hiding this comment.
I'm pretty sure we talked about enabling this by default, but just want to validate my memory on that @mjbvz @DanielRosenwasser
|
Thanks! |
| @@ -1110,6 +1110,12 @@ | |||
| "default": "allOpenProjects", | |||
| "markdownDescription": "%typescript.workspaceSymbols.scope%", | |||
| "scope": "window" | |||
| }, | |||
| "typescript.suggest.includeCompletionsWithClassMemberSnippets": { | |||
There was a problem hiding this comment.
Actually one quick note, I am going to split this into two settings: one for JS and one for TS
There was a problem hiding this comment.
I didn't add one for JavaScript because we are not supporting this completion feature in JS yet
There was a problem hiding this comment.
Oh right! I forgot about that.
There was a problem hiding this comment.
we are not supporting this completion feature in JS yet
But it'll come to JS sometime in the future, right?
There was a problem hiding this comment.
I think supporting JS would be nice. I created an issue to track that, feel free to upvote it: microsoft/TypeScript#46738
This PR fixes microsoft/TypeScript#45670
TS protocol update: microsoft/TypeScript#46370