Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly fix #133687 #136085

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Properly fix #133687 #136085

merged 1 commit into from
Oct 29, 2021

Conversation

jeanp413
Copy link
Contributor

This PR fixes #133687

@meganrogge sorry for bothering you again but 54ab46f caused a regression when creating terminals using the location API location: {parentTerminal} from an extension

const terminal1 = vscode.window.createTerminal({ name: `Term 1` });
terminal1.show();

const terminal2 = vscode.window.createTerminal({ name: `Term 2` });
terminal2.show();

const terminal3 = vscode.window.createTerminal({ name: `Term 3`, location: {parentTerminal: terminal2} });
terminal3.show();

Running this will create all three terminal in a single group (the panel must be hidden initially)

@meganrogge meganrogge added this to the November 2021 milestone Oct 29, 2021
@meganrogge meganrogge merged commit 27eff83 into microsoft:main Oct 29, 2021
@jeanp413 jeanp413 deleted the fix-133687 branch October 29, 2021 23:34
Tyriar pushed a commit that referenced this pull request Nov 1, 2021
Tyriar added a commit that referenced this pull request Nov 1, 2021
@rzhao271 rzhao271 modified the milestones: November 2021, October 2021 Nov 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on window reload, terminal order is shuffled
3 participants