Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Path of files with '#' is cut in Markers resource (Problems) #136588 #136589

Closed
wants to merge 1 commit into from
Closed

Conversation

Jiogo18
Copy link

@Jiogo18 Jiogo18 commented Nov 6, 2021

This PR fixes #136588.

problemCollectors use URI.parse(resource) to get the path of the "error" but it's a file.
➡️ Replaced by URI.file(resource).

What I checked:

@ghost
Copy link

ghost commented Nov 6, 2021

CLA assistant check
All CLA requirements met.

Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This negatively changes how Uri#file works and cannot be merged. The file util isn't to parse extensions and no decoding can happen here

@jrieken jrieken self-assigned this Nov 8, 2021
@Jiogo18
Copy link
Author

Jiogo18 commented Sep 11, 2022

Solved in #136588, thanks.

@Jiogo18 Jiogo18 closed this Sep 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files with a '#' character can't be opened when an error occurs ('Problems' menu)
2 participants