Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call stack items aren't opening tabs with correct contents #136684

Closed
eamodio opened this issue Nov 8, 2021 · 9 comments
Closed

Call stack items aren't opening tabs with correct contents #136684

eamodio opened this issue Nov 8, 2021 · 9 comments
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Nov 8, 2021

While debugging extensions, if I stop at a break point and try to walk back up the call stack, the tabs that get opened from the call stack view have the correct tab name, but don't initially have the correct contents. But if you switch to a different tab and then back, the proper contents get shown.

This started quite recently (in insiders).

missing-debug-content

/cc @connor4312 @bpasero

@joyceerhl joyceerhl assigned connor4312 and unassigned weinand Nov 8, 2021
@connor4312 connor4312 assigned roblourens and unassigned connor4312 Nov 8, 2021
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Nov 8, 2021
@roblourens
Copy link
Member

I saw this yesterday but didn't have time to debug. Nothing has changed in debug's end. Any idea @bpasero @lramos15?

@roblourens roblourens added info-needed Issue requires more information from poster bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority and removed info-needed Issue requires more information from poster labels Nov 9, 2021
@roblourens roblourens added this to the November 2021 milestone Nov 9, 2021
@bpasero
Copy link
Member

bpasero commented Nov 9, 2021

No idea from my end, would be good to have a simple repro.

@bpasero
Copy link
Member

bpasero commented Nov 9, 2021

One thing I did change recently, not sure whether it could be the reason though: when you call openEditor and there is another call right after that would cancel the first one, undefined is returned. Previously we would return the editor pane even though the opening was cancelled.

Refs: 6ed67dd

@weinand
Copy link
Contributor

weinand commented Nov 9, 2021

I couldn't reproduce this.
Does the problem reproduce if you run VS Code without extensions?

@weinand weinand added the info-needed Issue requires more information from poster label Nov 9, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Nov 9, 2021

I can reproduce this consistently. You just need an item in the callstack that is from a file that's different from the topmost item.

@rchiodo
Copy link
Contributor

rchiodo commented Nov 9, 2021

Repro steps for me

It activates the tab, but the contents are from the jsonOutline.ts file:

image

@weinand
Copy link
Contributor

weinand commented Nov 9, 2021

@rchiodo thanks for the steps, now I can reproduce!

(without your detailled steps I was trying a web-packed extension which only has one underlying *.js file but maps to many *.ts files).

In my case (on macOS) I do not see the wrong contents, but no contents at all:

2021-11-09_18-40-16 (1)

@bpasero bpasero removed the info-needed Issue requires more information from poster label Nov 10, 2021
@bpasero bpasero added the author-verification-requested Issues potentially verifiable by issue author label Nov 20, 2021
@rchiodo rchiodo added author-verification-requested Issues potentially verifiable by issue author and removed author-verification-requested Issues potentially verifiable by issue author labels Dec 3, 2021
@rchiodo rchiodo added the verified Verification succeeded label Dec 3, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Dec 3, 2021

/verified. Opened tabs are correct.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

7 participants
@roblourens @eamodio @bpasero @weinand @connor4312 @rchiodo and others