Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument accepted suggestion contributions #136922

Merged
merged 6 commits into from
Nov 12, 2021
Merged

Instrument accepted suggestion contributions #136922

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
798e197
Instrument accepted suggestion contributions
Nov 11, 2021
f588406
Only log once per resource/provider
Nov 11, 2021
8a82db9
Keep track of logged events for real
Nov 11, 2021
72c7be8
Move types closer to use
Nov 11, 2021
533f91a
Address feedback
Nov 12, 2021
dfb6332
Tidy up
Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/vs/editor/contrib/suggest/suggestController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ import { CommitCharacterController } from './suggestCommitCharacters';
import { State, SuggestModel } from './suggestModel';
import { OvertypingCapturer } from './suggestOvertypingCapturer';
import { ISelectedSuggestion, SuggestWidget } from './suggestWidget';
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
import { basename, extname } from 'vs/base/common/resources';
import { hash } from 'vs/base/common/hash';

// sticky suggest widget which doesn't disappear on focus out and such
let _sticky = false;
Expand Down Expand Up @@ -122,6 +125,7 @@ export class SuggestController implements IEditorContribution {
@IContextKeyService private readonly _contextKeyService: IContextKeyService,
@IInstantiationService private readonly _instantiationService: IInstantiationService,
@ILogService private readonly _logService: ILogService,
@ITelemetryService private readonly _telemetryService: ITelemetryService,
) {
this.editor = editor;
this.model = _instantiationService.createInstance(SuggestModel, this.editor,);
Expand Down Expand Up @@ -427,11 +431,35 @@ export class SuggestController implements IEditorContribution {

// clear only now - after all tasks are done
Promise.all(tasks).finally(() => {
this._reportSuggestionAcceptedTelemetry(model, event);

this.model.clear();
cts.dispose();
});
}

private _telemetryGate: number = 0;
private _reportSuggestionAcceptedTelemetry(model: ITextModel, acceptedSuggestion: ISelectedSuggestion) {
if (this._telemetryGate++ % 100 !== 0) {
return;
}

type AcceptedSuggestion = { providerId: string; fileExtension: string; languageId: string; basenameHash: string; };
type AcceptedSuggestionClassification = {
providerId: { classification: 'PublicNonPersonalData'; purpose: 'FeatureInsight'; };
basenameHash: { classification: 'PublicNonPersonalData'; purpose: 'FeatureInsight'; };
fileExtension: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; };
languageId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; };
};

this._telemetryService.publicLog2<AcceptedSuggestion, AcceptedSuggestionClassification>('suggest.acceptedSuggestion', {
providerId: acceptedSuggestion.item.provider._debugDisplayName ?? 'unknown',
basenameHash: hash(basename(model.uri)).toString(16),
languageId: model.getLanguageId(),
fileExtension: extname(model.uri),
});
}

getOverwriteInfo(item: CompletionItem, toggleMode: boolean): { overwriteBefore: number, overwriteAfter: number } {
assertType(this.editor.hasModel());

Expand Down