Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer breaker in browser/contextScopedHistoryWidget.ts#L14 #140856

Closed
egamma opened this issue Jan 17, 2022 · 1 comment
Closed

Layer breaker in browser/contextScopedHistoryWidget.ts#L14 #140856

egamma opened this issue Jan 17, 2022 · 1 comment
Assignees
@connor4312
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Milestone
February 2022

Comments

@egamma
Copy link
Member

egamma commented Jan 17, 2022 •
edited

The following import added with a596318 adds a layer breaker from platform to editor

vscode/src/vs/platform/browser/contextScopedHistoryWidget.ts

Line 14 in 347f954

import { Context as SuggestContext } from 'vs/editor/contrib/suggest/suggest';

@egamma egamma mentioned this issue Jan 17, 2022
Closed
@sglebs sglebs mentioned this issue Jan 17, 2022
Closed
@alexdima alexdima added the engineering VS Code - Build / issue tracking / etc. label Jan 19, 2022
@alexdima
Copy link
Member

This is now also flagged by our eslint rules. (#140984)

@alexdima alexdima mentioned this issue Jan 19, 2022
Closed
@connor4312 connor4312 added the debt Code quality issues label Jan 19, 2022
@connor4312 connor4312 added this to the February 2022 milestone Jan 19, 2022
alexdima added a commit that referenced this issue Jan 20, 2022
@alexdima
Avoid layer breaker import (#140856)
06c13b6
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
February 2022
Development

No branches or pull requests
4 participants
@egamma @connor4312 @alexdima and others