Task terminals with a failed process task aren't always reused properly
#141939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Feb 1, 2022
| @@ -1412,7 +1412,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance { | |||
| } | |||
|
|
|||
| // First onExit to consumers, this can happen after the terminal has already been disposed. | |||
| this._onExit.fire(this._exitCode); | |||
| this._onExit.fire(parsedExitResult); | |||
There was a problem hiding this comment.
The introduction of null seems pretty confusing, could this instead fire exitCodeOrError which would let you check message directly? If exitCodeOrError is an ITerminalLaunchError then the terminal failed before the process launched which is the case you're after.
There was a problem hiding this comment.
The message is localized, so I'm not sure what I should check for there.
Checking if exitCodeOrError is an ITerminalLaunchError will work though. I didn't realize it would only be an ITerminalLaunchError when the terminal failed before the process launched.
There was a problem hiding this comment.
parsedExitResult is localized for the notification, exitCodeOrError.message isn't though.
|
Thanks for reviewing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141728