Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow creating a terminal in an empty workspace #141971

Merged
merged 2 commits into from
Feb 2, 2022
Merged

allow creating a terminal in an empty workspace #141971

merged 2 commits into from
Feb 2, 2022

Conversation

meganrogge
Copy link
Contributor

This pr fixes #141463

@meganrogge meganrogge changed the title fix #141463 allow creating a terminal in an empty workspace Feb 1, 2022
@meganrogge meganrogge self-assigned this Feb 1, 2022
@meganrogge meganrogge added this to the February 2022 milestone Feb 1, 2022
@meganrogge
Copy link
Contributor Author

remote integration tests are failing on linux (and maybe mac?)

@meganrogge
Copy link
Contributor Author

meganrogge commented Feb 1, 2022 •
edited

ok so here's the problem:
Screen Shot 2022-02-01 at 4 45 00 PM
likely because this is true

vscode/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts

Line 1369 in 3343640

} else if (this._cwd !== this._userHome) {

@meganrogge
Copy link
Contributor Author

failures are unrelated ✅

@meganrogge meganrogge merged commit a3053f7 into main Feb 2, 2022
@meganrogge meganrogge deleted the merogge/workspace branch February 2, 2022 20:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Awaiting requested review from Tyriar

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
February 2022
Development

Successfully merging this pull request may close these issues.

Opening a terminal in an empty restricted window
1 participant
@meganrogge