Add border to status bar items on keyboard focus #142665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall, this is looking good and like that we are finally using a proper focus border in the status bar!
@bpasero I wonder if there's anything we can do here to just add an additional 1px padding to increase the status bar for themes that use this? things already shift when you switch to a theme with borders so I don't see this being a big issue |
bpasero
approved these changes
Feb 10, 2022
raghavthind2005
approved these changes
Feb 10, 2022
|
Just tried this out now and this is great work @daviddossett 👏 |
This was referenced Feb 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #141709 by adding an outline to status bar items when navigating through them with the keyboard.
Additionally, the focus outline offset changes slightly for themes that include a
statusBar.bordercolor.153275287-06205734-e569-4b9b-b3a1-2beaa4169638.mp4