Allow stack frame without source as top stack frame when using disassembly view #143649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roblourens @weinand Can you please take a look at this PR? |
weinand
added
the
debug
raghavthind2005
approved these changes
Mar 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there's a top stack frame that doesn't have source code but has instructionPointerReference, it was not considered as top stack frame regardless of the view. However, in this case, disassembly is available, and therefore causes confusion. In this PR, top frame finding logic is changed so when using disassembly view, stack frame without source and with instructionPointerReference is allowed to be top stack frame.