Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Settings editor narrow total width #145358

Merged
merged 1 commit into from Mar 21, 2022

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Mar 17, 2022

Fixes #145243
Fixes #143690

We increase the Settings editor narrow total width. In turn, the ToC only shows up when the Settings editor is wide enough.

Pros:

  • When the ToC shows up, it doesn't show up ridiculously narrow.
  • When the ToC shows up, the sash already has 100px of wiggle room.

Cons:

  • The splitview total width must be at least 700px wide for the ToC to even show up. This is calculated based on the ToC reset width, which is 200px, as well as the editor side min width, which is currently at 500px. The editor side min width is that wide because we currently don't have a horizontal scroll bar for the editor side in case of min overflow, and because string setting inputboxes are currently very long, in case they represent path settings. "Editor side" means the non-ToC portion of the Settings editor, in this case.

Considering how users who use VS Code with a narrower width might get annoyed at the ToC not showing up, a better solution is probably to figure out how to add a horizontal scrollbar to just the editor side in case it is too narrow.

Adding @misolori as a reviewer for thoughts on this issue.
Also CC @stevencl.

@rzhao271 rzhao271 added this to the March 2022 milestone Mar 17, 2022
@rzhao271 rzhao271 self-assigned this Mar 17, 2022
Copy link
Contributor

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, here are the screenshots of where the narrow view kicks in:

CleanShot 2022-03-21 at 11 47 29@2x

CleanShot 2022-03-21 at 11 46 13@2x

@rzhao271 rzhao271 merged commit 514fb29 into main Mar 21, 2022
@rzhao271 rzhao271 deleted the rzhao271/narrow-total-width-increase branch March 21, 2022 18:50
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants