-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension activation fails as env
is null when restoring VSCode
#14632
Comments
This seems related to 2f8c5c1. |
Downloaded older Insider builds: It's somewhere in here I believe: @alexandrudima |
I'd say this is caused by this line of code. We have it since a long time but my assumption is that recent changes in the extension startup sequence is now triggering this... |
To verify: Write an extension that activates on start up (
|
@jrieken works fine when calling from within the I cannot reproduce this from Code stable when I log env right after the vscode import. |
@bpasero You are not on latest! There the variable is called |
@jrieken ah ok sorry. |
Verified on Mac this works 👍 |
Today I noticed language extensions like https://github.com/Dart-Code/Dart-Code and https://github.com/DonJayamanne/pythonVSCode failed to activate.
Both fails as
env
is null when being activated. Dart for example:The line in trouble:
(Put a log, will use it soon in gif)
This is in the beginning of that file:
Now, if I go to a Dart project and open a dart file, the Dart extension will activate correctly. However, if I leave an open tab, and restart VSCode, so it restores the tab, Dart extension fails to activate, as
env
is null.Also happened to @roblourens
I'll be available tonight. Let me know how can I help if you can't repro.
The text was updated successfully, but these errors were encountered: