Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle some URIs in new windows #146711

Merged
merged 4 commits into from Apr 4, 2022
Merged

Handle some URIs in new windows #146711

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
19970cd
handle URI in new windows
joaomoreno Apr 4, 2022
b46079a
make sure to remove the windowId query param
joaomoreno Apr 4, 2022
0293f77
Merge branch 'main' into joao/handle-uri-new-window
joaomoreno Apr 4, 2022
0f8912a
Merge branch 'main' into joao/handle-uri-new-window
joaomoreno Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/vs/code/electron-main/app.ts
View file
Open in desktop
Expand Up @@ -876,9 +876,21 @@ export class CodeApplication extends Disposable {
return true;
}

// If we have not yet handled the URI and we have no window opened (macOS only)
// we first open a window and then try to open that URI within that window
if (isMacintosh && windowsMainService.getWindowCount() === 0) {
// We should handle the URI in a new window if no window is open (macOS only)
let shouldOpenInNewWindow = isMacintosh && windowsMainService.getWindowCount() === 0;

// or if the URL contains `windowId=_blank`
if (!shouldOpenInNewWindow) {
const params = new URLSearchParams(uri.query);

if (params.get('windowId') === '_blank') {
params.delete('windowId');
uri = uri.with({ query: params.toString() });
shouldOpenInNewWindow = true;
}
}

if (shouldOpenInNewWindow) {
const [window] = windowsMainService.open({
context: OpenContext.API,
cli: { ...environmentService.args },
Expand Down