Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #147420 #147930

Merged
merged 3 commits into from Apr 25, 2022
Merged

Fixes #147420 #147930

merged 3 commits into from Apr 25, 2022

Conversation

100paperkite
Copy link
Contributor

@100paperkite 100paperkite commented Apr 22, 2022 •
edited

This PR fixes #147420

Searching GitHub repo by {owner}/{part of repo name} sometimes returns nothing.
image

I change query to search repo by user:{owner}+{search word} if the input text contains the owner. This query returns all owner's repositories that contains the search word.

Before

before

After

after

@ghost
Copy link

ghost commented Apr 22, 2022 •
edited by ghost

CLA assistant check
All CLA requirements met.

@joaomoreno joaomoreno added this to the April 2022 milestone Apr 25, 2022
@joaomoreno joaomoreno added the github Github extension label Apr 25, 2022
joaomoreno
joaomoreno requested changes Apr 25, 2022
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You actually broke getBranches, that used to call parse and you forgot to change it to call parseUrl.

I'll fix it up and merge it.

@joaomoreno joaomoreno merged commit 9319978 into microsoft:main Apr 25, 2022
aeschli pushed a commit that referenced this pull request May 2, 2022
@100paperkite @joaomoreno @aeschli
Fixes #147420 (#147930)
3a224ea 
Co-authored-by: João Moreno <joao.moreno@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno requested changes

Assignees

@joaomoreno joaomoreno

Labels
github Github extension
Projects
None yet
Milestone
April 2022
Development

Successfully merging this pull request may close these issues.

git.clone command does not display repo search results correctly
2 participants
@100paperkite @joaomoreno