Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit and quality in server paths #148707

Merged
merged 5 commits into from
May 6, 2022
Merged

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented May 4, 2022

Continuation of #147311

All server paths should have as first segment quality-commit. That way we can have a server-server that can serve multiple versions of the remote bits.

This PR adds

  • server path root for the /vscode-remote-resource request
  • server root path for the websocket connection

@aeschli aeschli requested a review from alexdima May 4, 2022 13:29
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I spotted a coding error. See comments. Otherwise, this looks good to me, but I was wondering if we should trigger a build to test it out before merging to main ?

src/vs/server/node/webClientServer.ts Outdated Show resolved Hide resolved
src/vs/server/node/webClientServer.ts Outdated Show resolved Hide resolved
@aeschli aeschli merged commit ac123b7 into main May 6, 2022
@aeschli aeschli deleted the aeschli/commitInRemoteResourceRoute branch May 6, 2022 08:51
@aeschli aeschli added this to the May 2022 milestone May 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants