Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate error fragment #149760

Merged
merged 1 commit into from May 17, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/vs/platform/telemetry/common/errorTelemetry.ts
Expand Up @@ -10,14 +10,16 @@ import { safeStringify } from 'vs/base/common/objects';
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';

type ErrorEventFragment = {
callstack: { classification: 'CallstackOrException'; purpose: 'PerformanceAndHealth' };
msg?: { classification: 'CallstackOrException'; purpose: 'PerformanceAndHealth' };
file?: { classification: 'CallstackOrException'; purpose: 'PerformanceAndHealth' };
line?: { classification: 'CallstackOrException'; purpose: 'PerformanceAndHealth'; isMeasurement: true };
column?: { classification: 'CallstackOrException'; purpose: 'PerformanceAndHealth'; isMeasurement: true };
uncaught_error_name?: { classification: 'CallstackOrException'; purpose: 'PerformanceAndHealth' };
uncaught_error_msg?: { classification: 'CallstackOrException'; purpose: 'PerformanceAndHealth' };
count?: { classification: 'CallstackOrException'; purpose: 'PerformanceAndHealth'; isMeasurement: true };
owner: 'lramos15, sbatten'
comment: 'Whenever an error in VS Code is thrown.'
callstack: { classification: 'CallstackOrException'; purpose: 'PerformanceAndHealth', comment: 'The callstack of the error.' };
msg?: { classification: 'CallstackOrException'; purpose: 'PerformanceAndHealth', comment: 'The message of the error. Normally the first line int the callstack.' };
file?: { classification: 'CallstackOrException'; purpose: 'PerformanceAndHealth', comment: 'The file the error originated from.'};
line?: { classification: 'CallstackOrException'; purpose: 'PerformanceAndHealth'; isMeasurement: true, comment: 'The line the error originate on.' };
column?: { classification: 'CallstackOrException'; purpose: 'PerformanceAndHealth'; isMeasurement: true, comment: 'The column of the line which the error orginated on.'};
uncaught_error_name?: { classification: 'CallstackOrException'; purpose: 'PerformanceAndHealth', comment: 'If the error is uncaught what is the error type' };
uncaught_error_msg?: { classification: 'CallstackOrException'; purpose: 'PerformanceAndHealth', comment: 'If the error is uncaught this is just msg but for uncaught errors.' };
count?: { classification: 'CallstackOrException'; purpose: 'PerformanceAndHealth'; isMeasurement: true, comment: 'How many times this error has been thrown' };
};
export interface ErrorEvent {
callstack: string;
Expand Down