Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cancelling webview's readFileStream calls #149964

Merged
merged 1 commit into from May 19, 2022
Merged

Allow cancelling webview's readFileStream calls #149964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/webview/browser/resourceLoading.ts
View file
Open in desktop
Expand Up @@ -65,7 +65,7 @@ export async function loadLocalResource(
const mime = getWebviewContentMimeType(requestUri); // Use the original path for the mime

try {
const result = await fileService.readFileStream(resourceToLoad, { etag: options.ifNoneMatch });
const result = await fileService.readFileStream(resourceToLoad, { etag: options.ifNoneMatch }, token);
return new WebviewResourceResponse.StreamSuccess(result.value, result.etag, result.mtime, mime);
} catch (err) {
if (err instanceof FileOperationError) {
Expand Down