json: use default word pattern #151754
Merged
json: use default word pattern #151754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON work pattern was special in that it included the quotes for string literals.
This caused abnormalities with quick suggest (#32480), expand selection (#127264) and others.
The change impacts completion providers on JSON documents. The default replace range now only covers words, no longer the full JSON token. Also
document.getWordRangeAtPositionjust returns the (natural) word at the position.The PR adopts the configuration-editing and extension-editing providers and fixes several issues in these providers.
Fixes #127264
Fixes #68936
Fixed #32480
Fixes #147006