Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: allow adapters to be deprecated #151973

Merged
merged 1 commit into from Jun 14, 2022
Merged

debug: allow adapters to be deprecated #151973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/vs/workbench/contrib/debug/common/debug.ts
View file
Open in desktop
Expand Up @@ -779,6 +779,7 @@ export interface IDebuggerContribution extends IPlatformSpecificAdapterContribut
configurationSnippets?: IJSONSchemaSnippet[];
variables?: { [key: string]: string };
when?: string;
deprecated?: string;
uiMessages?: { [key in DebuggerUiMessage]: string };
}

Expand Down
5 changes: 5 additions & 0 deletions src/vs/workbench/contrib/debug/common/debugSchemas.ts
View file
Open in desktop
Expand Up @@ -72,6 +72,11 @@ export const debuggersExtPoint = extensionsRegistry.ExtensionsRegistry.registerE
type: 'string',
default: ''
},
deprecated: {
description: nls.localize('vscode.extension.contributes.debuggers.deprecated', "Optional message to mark this debug type as being deprecated."),
type: 'string',
default: ''
},
windows: {
description: nls.localize('vscode.extension.contributes.debuggers.windows', "Windows specific settings."),
type: 'object',
Expand Down
3 changes: 2 additions & 1 deletion src/vs/workbench/contrib/debug/common/debugger.ts
View file
Open in desktop
Expand Up @@ -236,7 +236,8 @@ export class Debugger implements IDebugger, IDebuggerMetadata {
enumDescriptions: [this.label],
description: nls.localize('debugType', "Type of configuration."),
pattern: '^(?!node2)',
deprecationMessage: this.enabled ? undefined : debuggerDisabledMessage(this.type),
deprecationMessage: this.debuggerContribution.deprecated || (this.enabled ? undefined : debuggerDisabledMessage(this.type)),
doNotSuggest: !!this.debuggerContribution.deprecated,
errorMessage: nls.localize('debugTypeNotRecognised', "The debug type is not recognized. Make sure that you have a corresponding debug extension installed and that it is enabled."),
patternErrorMessage: nls.localize('node2NotSupported', "\"node2\" is no longer supported, use \"node\" instead and set the \"protocol\" attribute to \"inspector\".")
};
Expand Down