Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate declarations in terminal #153280

Merged
merged 1 commit into from Jun 27, 2022
Merged

Remove duplicate declarations in terminal #153280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/vs/platform/terminal/common/terminal.ts
View file
Open in desktop
Expand Up @@ -181,11 +181,6 @@ export enum TitleEventSource {
export type ITerminalsLayoutInfo = IRawTerminalsLayoutInfo<IPtyHostAttachTarget | null>;
export type ITerminalsLayoutInfoById = IRawTerminalsLayoutInfo<number>;

export interface IRawTerminalInstanceLayoutInfo<T> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See line 137 for the duplicate definition.

relativeSize: number;
terminal: T;
}

export enum TerminalIpcChannels {
/**
* Communicates between the renderer process and shared process.
Expand Down
5 changes: 0 additions & 5 deletions src/vs/workbench/contrib/terminal/common/terminal.ts
View file
Open in desktop
Expand Up @@ -454,11 +454,6 @@ export interface IStartExtensionTerminalRequest {
callback: (error: ITerminalLaunchError | undefined) => void;
}

export interface IDefaultShellAndArgsRequest {
useAutomationShell: boolean;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See line 361 for duplicate definition.

callback: (shell: string, args: string[] | string | undefined) => void;
}

export const QUICK_LAUNCH_PROFILE_CHOICE = 'workbench.action.terminal.profile.choice';

export const enum TerminalCommandId {
Expand Down