Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron - log unexpected setJumpList result #154228

Merged
merged 1 commit into from Jul 6, 2022
Merged

electron - log unexpected setJumpList result #154228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/vs/platform/workspaces/electron-main/workspacesHistoryMainService.ts
View file
Open in desktop
Expand Up @@ -377,7 +377,10 @@ export class WorkspacesHistoryMainService extends Disposable implements IWorkspa
});

try {
app.setJumpList(jumpList);
const res = app.setJumpList(jumpList);
if (res && res !== 'ok') {
this.logService.warn(`updateWindowsJumpList#setJumpList unexpected result: ${res}`);
}
} catch (error) {
this.logService.warn('updateWindowsJumpList#setJumpList', error); // since setJumpList is relatively new API, make sure to guard for errors
}
Expand Down