Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix md document links for untitled files #155248

Merged
merged 2 commits into from Jul 15, 2022
Merged

Fix md document links for untitled files #155248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1313a2b
Fix md document links for untitled files
mjbvz Jul 14, 2022
713ec79
Unskip fixed test
mjbvz Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion extensions/markdown-language-features/server/src/workspace.ts
View file
Open in desktop
Expand Up @@ -162,7 +162,10 @@ export class VsCodeClientWorkspace implements md.IWorkspace {
}
}

stat(resource: URI): Promise<md.FileStat | undefined> {
async stat(resource: URI): Promise<md.FileStat | undefined> {
if (this._documentCache.has(resource) || this.documents.get(resource.toString())) {
return { isDirectory: false };
}
return this.connection.sendRequest(protocol.statFileRequestType, { uri: resource.toString() });
}

Expand Down
2 changes: 1 addition & 1 deletion extensions/markdown-language-features/src/test/documentLink.test.ts
View file
Open in desktop
Expand Up @@ -134,7 +134,7 @@ async function getLinksForFile(file: vscode.Uri): Promise<vscode.DocumentLink[]>
}
});

test.skip('Should navigate to fragment within current untitled file', async () => { // TODO: skip for now for ls migration
test('Should navigate to fragment within current untitled file', async () => { // TODO: skip for now for ls migration
const testFile = workspaceFile('x.md').with({ scheme: 'untitled' });
await withFileContents(testFile, joinLines(
'[](#second)',
Expand Down