update traffic lights on macos when title bar zooms

[sbatten]

fixes #155557

This adopts the same technique as Windows because we need to know about the titlebar's counter zoom behavior. however, it removes the workaround for electron/electron#34822 which should be fixed in 18.3.6 when released and adopted

[bpasero]

I think this is generally an elegant solution but:

• we cannot merge this before we updated Electron and I am not sure that happens soon, I am not even seeing that new Electron version released yet, maybe lobby in with Deepak
• I see a flicker on startup, and I think this is because the traffic lights now are only updated from the workbench which can load slow:
  

PS: I find updateTitleBarOverlay a bit misleading, this is not an overlay, this is updating the native window controls (maybe then call it "window control overlay").

[sbatten]

@bpasero pushed some changes based on the feedback. most of the startup flicker is caused by the electron bug, but I've also added caching to improve the new window experience. With the fix from electron and the caching, there should be minimal to no jumping.

[bpasero]

Please rather use the IStateMainService if you must cache something in electron-main, given:

vscode/src/vs/platform/storage/electron-main/storageMainService.ts

Lines 251 to 262 in 9aea0a6

	/**
	* Important: unlike other storage services in the renderer, the
	* main process does not await the storage to be ready, rather
	* storage is being initialized while a window opens to reduce
	* pressure on startup.
	*
	* As such, any client wanting to access application storage from the
	* main process needs to wait for `whenReady`, otherwise there is
	* a chance that the service operates on an in-memory store that
	* is not backed by any persistent DB.
	*/
	readonly whenReady: Promise<void>;

[bpasero]

Pushed a change to address this and gave it some testing on macOS, not Windows though. I am not sure if there is any downside in calling updateWindowControls on every startup even when the title area is not specially configured in any way.

[sbatten]

@bpasero thank you for that, i just test with the electron 19 build and it seems to work well